Uploaded image for project: 'FireBreath Core'
  1. FireBreath Core
  2. FIREBREATH-83

CMakeLists.txt overrides CMAKE_INSTALL_PREFIX

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: FireBreath 1.5.1
    • Fix Version/s: FireBreath 1.5.2
    • Operating System:
      Linux/FreeBSD
    • Web Browser:
      Firefox 4.x

      Description

      One of the changes in Firebreath 1.5 is that it now overrides CMAKE_INSTALL_PREFIX in root CMakeLists.txt file:
      <code>set (CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/install)</code>

      Please do not do that. This variable is supposed to be user configurable, but if you override it in CMakeLists.txt, user settings will have no effect. If there is a good reason to have a different default, set it in the prep* scripts so that it'd still be possible to get the standard behaviour by invoking cmake directly.

      My plugin relies on the variable and the value that's being forced on in FB's CMakeLists.txt hoses my plugin's installation.

      Quoting Michael Wild: "And NEVER EVER set CMAKE_INSTALL_PREFIX in your CMakeLists.txt file.
      That is a user-setting and you will make people angry at you if you
      override their choice in your code."
      http://www.cmake.org/pipermail/cmake/2010-November/040969.html

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                richard Richard Bateman
                Reporter:
                kalev Kalev Lember
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: