Uploaded image for project: 'FireBreath Core'
  1. FireBreath Core
  2. FIREBREATH-9

make_method modified to take 15 parameters

    XMLWordPrintable

    Details

    • Operating System:
      Windows
    • Web Browser:
      Firefox 3.x, Google Chrome, Internet Explorer 6-8

      Description

      I have modified MethodConvertor.h to take 15 parameters and changed the TestJSAPIAuto.h and jsapiauto_test.h to verify the changes made. Please find the changed files attached for future release.

      PS: Extract from http://groups.google.com/group/firebreath-dev/

      Currently make_method [in MethodConvertor.h] takes only 10 parameters,
      but the old active X control for which I am building a plugin takes 14
      parameters. So can I update the file and send it to FireBreath
      developers so that it can be added to the source code.

      Richard Bateman
      in a year and a half you're the first to need more than 10 parameters =]
      If you'd like to go ahead and update it to support up to 20 that would be fine. Could you also add some unit tests to tests/ScriptingCoreTest/TestJSAPIAuto.h and .../jsapiauto_test.h to verify that your additions work properly before we import them?
      The easiest way for us to get changes then is to pull them from your github fork, but if that's too much of a pain this is simple enough that you could just submit a jira issue and attach them.
      The change will go into 1.5; possibly 1.4.2 if you really need it there.
      Richard

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                richard Richard Bateman
                Reporter:
                catchfbinfo prachi v kulkarni
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: